feat: reduce reliance on metadata in structural_simplify
#3540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cancelled CI because there's no point in running it when this is known to be problematic |
5 tasks
AayushSabharwal
force-pushed
the
as/ss-no-metadata
branch
from
2a2b620 to
8f71f30
Compare
|
Rebased on top of #3543 for now |
AayushSabharwal
force-pushed
the
as/ss-no-metadata
branch
from
8f71f30 to
236a5f8
Compare
AayushSabharwal
force-pushed
the
v10
branch
2 times, most recently
from
cc94187 to
f543afa
Compare
AayushSabharwal
force-pushed
the
as/ss-no-metadata
branch
from
236a5f8 to
37e76ea
Compare
AayushSabharwal
force-pushed
the
as/ss-no-metadata
branch
from
37e76ea to
e5c40a6
Compare
AayushSabharwal
changed the title
structural_simplifystructural_simplify
AayushSabharwal
force-pushed
the
as/ss-no-metadata
branch
from
e5c40a6 to
4deb198
Compare
ChrisRackauckas
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't work yet, for a variety of reasons. #3528 is one of them.